He held the office of Justiciar [Scotland] between 1251 and 1255, and between 1257 and 1289. He inherited large estates in Galloway, Fife, and the Lothians.
He held the office of Constable of Scotland in 1270. On 4 February 1283/84 he was one of the nobles who engaged to maintain the succession to the Crown of Margaret of Scotland. In 1285 he was one of the six Guardians on the death of King Alexander III.